Bug 55978

Summary: WebKit2: Redo is broken
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Jeff Miller
Reported 2011-03-08 15:49:14 PST
If you undo an edit command, you cannot redo it. This is because WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() are registering the wrong edit command when an undo or redo happens. For example, when we unapply(), we should register a Redo command, not an Undo command.
Attachments
Patch (1.83 KB, patch)
2011-03-08 15:53 PST, Jeff Miller 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-03-08 15:53:03 PST
Created attachment 85103 [details] Patch
Jeff Miller
Comment 2 2011-03-08 16:18:50 PST
Committed r80603: <http://trac.webkit.org/changeset/80603>
Note You need to log in before you can comment on or make changes to this bug.