Bug 55976

Summary:

Provisional URL should be loaded when restoring session state even if there are back / forward list entries

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

WebKit2

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	beidson: review+, beidson: commit-queue-

Description Mark Rowe (bdash) 2011-03-08 15:33:44 PST

As per the FIXME at <http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp?rev=80391#L175>.

Comment 1 Mark Rowe (bdash) 2011-03-08 15:35:53 PST

Created attachment 85100 [details]
Patch

Comment 2 Brady Eidson 2011-03-08 15:38:18 PST

Comment on attachment 85100 [details]
Patch

Looks fine.  Except I'm wondering if the sandboxExtensionHandle is needed in the new message also?  I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.

Comment 3 Mark Rowe (bdash) 2011-03-08 15:40:27 PST

(In reply to comment #2)
> (From update of attachment 85100 [details])
> Looks fine.  Except I'm wondering if the sandboxExtensionHandle is needed in the new message also?  I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.

WebPage::restoreSessionAndNavigateToCurrentItem passes it to goToBackForwardItem.  It’s not used at all within restoreSession.

Thanks for the review!