Bug 55956

Summary: WebKit2 Changes to correct WinCairo port build
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Build corrections for WinCairo
none
Get rid of tabs!
none
Correct <stdint.h> include ordering andersca: review+

Description Brent Fulgham 2011-03-08 11:53:05 PST 
The recent changes to the WebKit2 rendering logic do not build properly under WinCairo.  This issue collects the changes I made to get things building again.
Comment 1 Brent Fulgham 2011-03-08 11:57:55 PST 
Created attachment 85075 [details]
Build corrections for WinCairo
Comment 2 WebKit Review Bot 2011-03-08 12:00:40 PST 
Attachment 85075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:27:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/UIProcess/DrawingAreaProxy.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/win/WebView.cpp:1122:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2011-03-08 12:13:06 PST 
Created attachment 85076 [details]
Get rid of tabs!
Comment 4 WebKit Review Bot 2011-03-08 12:15:36 PST 
Attachment 85076 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/DrawingAreaProxy.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2011-03-08 12:19:32 PST 
Created attachment 85078 [details]
Correct <stdint.h> include ordering
Comment 6 Brent Fulgham 2011-03-08 15:36:46 PST 
Landed in  http://trac.webkit.org/changeset/80596.