Summary: | IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrei Popescu <andreip> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hans, jorlow, steveblock | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Andrei Popescu
2011-03-08 06:32:43 PST
Created attachment 85046 [details]
Patch
looks good Comment on attachment 85046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85046&action=review > Source/WebCore/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=55938 Should be ... <bug summary> <bug url> <additional details> <test status> > Source/WebKit/chromium/public/WebIDBCallbacks.h:-53 > - virtual void onSuccess(WebIDBObjectStore*) { WEBKIT_ASSERT_NOT_REACHED(); } Is this a leftover from jorlow's recent patch to remove this method? > Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:31 > +#include "IDBIndexBackendInterface.h" Intentional? Created attachment 85049 [details]
Patch
(In reply to comment #3) > (From update of attachment 85046 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85046&action=review > > > Source/WebCore/ChangeLog:8 > > + https://bugs.webkit.org/show_bug.cgi?id=55938 > > Should be ... > > <bug summary> > <bug url> > > <additional details> > > <test status> > Done. > > Source/WebKit/chromium/public/WebIDBCallbacks.h:-53 > > - virtual void onSuccess(WebIDBObjectStore*) { WEBKIT_ASSERT_NOT_REACHED(); } > > Is this a leftover from jorlow's recent patch to remove this method? > No, it's a leftover from my previous patch to remove onscucess(IDBObjectStore). I could not remove that method until doing the Chrome-side changes: http://src.chromium.org/viewvc/chrome?view=rev&revision=77281 Now that that's in, I can clean this up, too. > > Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:31 > > +#include "IDBIndexBackendInterface.h" > > Intentional? Yes, this was included transitively via WebIDBCallbacks.h. But since I removed it from that header, I had to add it here. Comment on attachment 85049 [details]
Patch
r=me
Committed r80564: <http://trac.webkit.org/changeset/80564> |