Bug 55917

Summary: [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, lucas.de.marchi, tkent, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
tkent: review+, tkent: commit-queue+
Modified Patch none

Gyuyoung Kim
Reported 2011-03-07 19:26:02 PST
ScrollbarEfl.cpp uses efl coding style. WebCore's efl port needs to follow WebKit style.
Attachments
Patch (7.17 KB, patch)
2011-03-07 20:17 PST, Gyuyoung Kim 		tkent: review+
tkent: commit-queue+
DetailsFormatted DiffDiff
Modified Patch (7.20 KB, patch)
2011-03-07 21:10 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-03-07 20:17:43 PST
Created attachment 85014 [details] Patch I change variables with more meaningful name.
Kent Tamura
Comment 2 2011-03-07 20:28:02 PST
Comment on attachment 85014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85014&action=review > Source/WebCore/platform/efl/ScrollbarEfl.cpp:176 > + message->val[0] = pos / (float)(tSize - vSize); We prefer C++-style casts though the style guide doesn't mention it. This should be static_cast<float>(tSize - vSize). > Source/WebCore/platform/efl/ScrollbarEfl.cpp:178 > + message->val[0] = 0.0; See "Floating point literals" in http://www.webkit.org/coding/coding-style.html > do not append .0, .f and .0f to floating point literals.
Gyuyoung Kim
Comment 3 2011-03-07 21:10:33 PST
Created attachment 85017 [details] Modified Patch I fix your point. :-)
WebKit Commit Bot
Comment 4 2011-03-07 23:05:16 PST
Comment on attachment 85017 [details] Modified Patch Clearing flags on attachment: 85017 Committed r80540: <http://trac.webkit.org/changeset/80540>
WebKit Commit Bot
Comment 5 2011-03-07 23:05:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.