Summary: | AX: Webkit2 not sending UAZoomFocusChanged notifications | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, buildbot, webkit-ews | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
chris fleizach
2011-03-07 18:13:13 PST
The problem is that we cannot convert the view bounds to screen coordinates because that method is not implemented in WK2 (whereas it is in WK1) Created attachment 85006 [details]
patch
Attachment 85006 [details] did not build on win: Build output: http://queues.webkit.org/results/8106635 Comment on attachment 85006 [details]
patch
This breaks Windows, but otherwise looks good.
Attachment 85006 [details] did not build on qt: Build output: http://queues.webkit.org/results/8103752 Created attachment 85054 [details]
patch
Attachment 85054 [details] did not build on qt: Build output: http://queues.webkit.org/results/8112013 Comment on attachment 85054 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=85054&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1182 > +WebCore::IntRect WebPage::windowToScreen(const WebCore::IntRect& rect) > +{ > + WebCore::IntRect screenRect; No need for the WebCore:: prefix here in the cpp file, although you do need it in the header. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1185 > + sendSync(Messages::WebPageProxy::WindowToScreen(rect), > + Messages::WebPageProxy::WindowToScreen::Reply(screenRect)); We normally don’t line up parentheses like this. in WebKit code. In fact, all on one line is the normal style. Attachment 85054 [details] did not build on win: Build output: http://queues.webkit.org/results/8104927 |