Bug 55916

Summary: AX: Webkit2 not sending UAZoomFocusChanged notifications
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
sam: review-
patch darin: review+

Description chris fleizach 2011-03-07 18:13:13 PST 
Webkit2 not sending UAZoomFocusChanged notifications

TO REPRO
-Turn on zoom
-Set zoom to follow keyboard focus
-Test zoom in TextEdit that zoom is following keyboard focus
-Start Safari&Webkit2
-Type text into a text field on a webpage

RESULTS
-Zoom does not follow KB focus
Comment 1 chris fleizach 2011-03-07 18:13:40 PST 
The problem is that we cannot convert the view bounds to screen coordinates because that method is not implemented in WK2 (whereas it is in WK1)
Comment 2 chris fleizach 2011-03-07 18:22:14 PST 
Created attachment 85006 [details]
patch
Comment 3 Build Bot 2011-03-07 18:53:56 PST 
Attachment 85006 [details] did not build on win:
Build output: http://queues.webkit.org/results/8106635
Comment 4 Sam Weinig 2011-03-07 19:48:25 PST 
Comment on attachment 85006 [details]
patch

This breaks Windows, but otherwise looks good.
Comment 5 Early Warning System Bot 2011-03-07 20:28:49 PST 
Attachment 85006 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8103752
Comment 6 chris fleizach 2011-03-08 09:28:49 PST 
Created attachment 85054 [details]
patch
Comment 7 Early Warning System Bot 2011-03-08 09:53:43 PST 
Attachment 85054 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8112013
Comment 8 Darin Adler 2011-03-08 09:55:02 PST 
Comment on attachment 85054 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85054&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1182
> +WebCore::IntRect WebPage::windowToScreen(const WebCore::IntRect& rect)
> +{
> +    WebCore::IntRect screenRect;

No need for the WebCore:: prefix here in the cpp file, although you do need it in the header.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1185
> +    sendSync(Messages::WebPageProxy::WindowToScreen(rect), 
> +             Messages::WebPageProxy::WindowToScreen::Reply(screenRect));

We normally don’t line up parentheses like this. in WebKit code. In fact, all on one line is the normal style.
Comment 9 Build Bot 2011-03-08 10:05:07 PST 
Attachment 85054 [details] did not build on win:
Build output: http://queues.webkit.org/results/8104927
Comment 10 chris fleizach 2011-03-08 10:19:13 PST 
http://trac.webkit.org/changeset/80569