Bug 55904
| Summary: | selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Minor | CC: | darin, enrica, eric, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 55902 | ||
| Bug Blocks: | |||
Ryosuke Niwa
Currently, EditorCommand is responsible for checking the value returned by shouldToggleStyleBasedOnStartOfSelection and calling either selectionHasStyle or selectionStartHasStyle. However, each port also calls selectionHasStyle in Source/WebKit without calling shouldToggleStyleBasedOnStartOfSelection and causing Mac port to behave inconsistently. We should merge these two functions so that selectionHasStyle calls selectionStartHasStyle as needed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Mn... this bug might be invalid after all. We do call selectionHasStyle in WebKit but only for text direction. And it seems odd to determine the direction of text merely based at the selection start.