Bug 55879

Summary: Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 55774    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 jorlow: review+

Steve Block
Reported 2011-03-07 08:14:08 PST
Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
Attachments
Patch 1 (13.55 KB, patch)
2011-03-07 08:19 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.68 KB, patch)
2011-03-07 08:21 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch 3 (13.59 KB, patch)
2011-03-07 10:58 PST, Steve Block 		jorlow: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-07 08:19:13 PST
Created attachment 84947 [details] Patch 1
Steve Block
Comment 2 2011-03-07 08:21:23 PST
Created attachment 84948 [details] Patch 2
Steve Block
Comment 3 2011-03-07 08:24:33 PST
Looks like the patch won't apply properly until the patch in Bug 55774 lands.
Steve Block
Comment 4 2011-03-07 10:58:41 PST
Created attachment 84956 [details] Patch 3
Jeremy Orlow
Comment 5 2011-03-07 11:02:57 PST
Comment on attachment 84956 [details] Patch 3 rubber stamp = me
Steve Block
Comment 6 2011-03-07 13:53:39 PST
Committed r80494: <http://trac.webkit.org/changeset/80494>
WebKit Review Bot
Comment 7 2011-03-07 14:44:33 PST
http://trac.webkit.org/changeset/80494 might have broken Chromium Mac Release
Steve Block
Comment 8 2011-03-07 14:47:23 PST
> http://trac.webkit.org/changeset/80494 might have broken Chromium Mac Release The break appears unrelated to my change. In file included from /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/cf/RunLoopTimerCF.cpp:30: ../platform/RunLoopTimer.h:32:26: error: SchedulePair.h: No such file or directory http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/20334/steps/compile-webkit/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.