Bug 55853
| Summary: | Move MD5/SHA1 tests to somewhere outside their constructors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yuta Kitamura <yutak> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | tkent |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 21010 | ||
| Bug Blocks: | |||
Yuta Kitamura
WTF::MD5 and WTF::SHA1 classes run unit tests in their constructors. We should move these somewhere else.
Comment from Kent Tamura in bug 55039:
> I don't like having tests in SHA1.cpp and they are called by the constructor though I understand it's same as MD5.
> Would you file a bug about the test location of SHA1 and MD5, and add a FIXME comment please?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuta Kitamura
Making this bug depend on bug 21010, because C++ unit test should be a perfect place to put these tests.