Summary: | [Qt] Simplify how QWebFrame::requestedUrl() is obtained | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, tonikitoo | ||||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Caio Marcelo de Oliveira Filho
2011-03-06 06:49:17 PST
Created attachment 84888 [details]
patch
Comment on attachment 84888 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=84888&action=review Your changelog does not explain why this new code is equal to the old code, or why the old code is wrong. Are these edge cases not valid anymore? > Source/WebKit/qt/ChangeLog:9 > + so we now it'll be available in the DocumentLoader. know? Created attachment 84889 [details]
patch with improved ChangeLog
Antonio, added you to CC since most of the requestedUrl() was implemented by you back in time. Would be very helpful if you could take a look / review this patch, or point some one who would be able to review it. :-) Comment on attachment 84889 [details] patch with improved ChangeLog Clearing flags on attachment: 84889 Committed r80768: <http://trac.webkit.org/changeset/80768> All reviewed patches have been landed. Closing bug. |