Bug 55825

Summary: Web Inspector: remove groupName from objectId
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version
pfeldman: review-
[patch] second iteration none

Description Ilya Tikhonovsky 2011-03-05 07:37:03 PST
%subj%
Comment 1 Ilya Tikhonovsky 2011-03-05 07:39:51 PST
Created attachment 84865 [details]
[patch] initial version
Comment 2 Pavel Feldman 2011-03-05 08:54:22 PST
Comment on attachment 84865 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=84865&action=review

> Source/WebCore/ChangeLog:9
> +        ():

Please remove these from ChangeLog.

> Source/WebCore/inspector/InjectedScriptSource.js:48
> +    this._idToObjectInfo = {};

Not all the objects have group names. I'd suggest that you simply create a separate map for id -> groupName binding. Otherwise, overhead.
Comment 3 Ilya Tikhonovsky 2011-03-08 13:40:44 PST
Created attachment 85087 [details]
[patch] second iteration

comments addressed
Comment 4 Ilya Tikhonovsky 2011-03-08 22:32:52 PST
Comment on attachment 85087 [details]
[patch] second iteration

Clearing flags on attachment: 85087

Committed r80623: <http://trac.webkit.org/changeset/80623>
Comment 5 Ilya Tikhonovsky 2011-03-08 22:33:02 PST
All reviewed patches have been landed.  Closing bug.