Bug 55818

Summary: Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andrey Adaikin
Reported 2011-03-05 02:05:58 PST
Newly inserted line rows may have the "lineNumber" property set (e.g. when inserting via a native Undo), thus interfering with the current numeration. We should also delete the "lineNumber" from line rows on DOMNodeRemoved event as a double defense.
Attachments
Patch (2.70 KB, patch)
2011-03-05 02:11 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-03-05 02:11:12 PST
Created attachment 84854 [details] Patch
Pavel Feldman
Comment 2 2011-03-05 03:38:51 PST
Comment on attachment 84854 [details] Patch Test?
Pavel Podivilov
Comment 3 2011-03-09 03:02:09 PST
Comment on attachment 84854 [details] Patch Clearing flags on attachment: 84854 Committed r80632: <http://trac.webkit.org/changeset/80632>
Pavel Podivilov
Comment 4 2011-03-09 03:02:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.