Bug 55796

Summary: [chromium] Baselines for media GPU layout tests
Product: WebKit Reporter: Victoria Kirst <vrk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dpranke, eric, kbr, mihaip, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Victoria Kirst 2011-03-04 15:05:39 PST 
[chromium] Baselines for media GPU layout tests
Comment 1 Victoria Kirst 2011-03-04 16:48:48 PST 
Created attachment 84831 [details]
Patch
Comment 2 WebKit Commit Bot 2011-03-04 23:41:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 84831 [details]:

http/tests/security/cross-origin-css.html bug 53035 (author: cevans@google.com)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-03-04 23:43:59 PST 
Comment on attachment 84831 [details]
Patch

Clearing flags on attachment: 84831

Committed r80411: <http://trac.webkit.org/changeset/80411>
Comment 4 WebKit Commit Bot 2011-03-04 23:44:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2011-03-07 02:52:16 PST 
http://trac.webkit.org/changeset/80411 might have broken Windows 7 Release (Tests)
Comment 7 Victoria Kirst 2011-03-07 13:22:39 PST 
(In reply to comment #6)
> How confident are we about these baselines? Looking at media/video-display-toggle.html in software vs. GPU, the video appears to be slightly wider, leading to some blurriness due to scaling and the right side of the dashed border not appearing:

Hi Mihai! These are known problems:
http://code.google.com/p/chromium/issues/detail?id=73234
http://code.google.com/p/chromium/issues/detail?id=74102

They are not especially quick and easy to fix, so I thought for now we would have slightly buggy baselines so that at least we would know when media tests are completely broken... but wasn't sure what was the best route for this. Otherwise I could wait until at least issue 74102 is fixed? (Would prefer not to be blocked on 73234 because I'm not sure what's causing it or how to fix it.)
Comment 8 Mihai Parparita 2011-03-07 13:28:58 PST 
(In reply to comment #7)
> They are not especially quick and easy to fix, so I thought for now we would have slightly buggy baselines so that at least we would know when media tests are completely broken... but wasn't sure what was the best route for this. Otherwise I could wait until at least issue 74102 is fixed? (Would prefer not to be blocked on 73234 because I'm not sure what's causing it or how to fix it.)

The reason why I asked is because these tests are failing on the Snow Leopard bot:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fvideo-display-toggle.html%2Cmedia%2Fvideo-no-audio.html%2Cmedia%2Fvideo-volume-slider.html&group=%40ToT%20GPU%20Mesa%20-%20chromium.org

The GPU/Mesa layout tests do not support Leopard vs. Snow Leopard baselines, so the tests are failing due to text anti-aliasing differences.

Generally, since Snow Leopard is the future, we've focused on checking in pixel baselines for it. That's why there's these lines in text_expectations.txt:

// We only maintain pixel GPU baselines for Snow Leopard
WONTFIX GPU MAC LEOPARD : compositing = IMAGE PASS
WONTFIX GPU MAC LEOPARD : platform/chromium/compositing = IMAGE PASS

Does it make sense to add a similar line for media/ and to update the baselines for those three tests to be for Snow Leopard?