Bug 55793

Summary: Add WKPageValidateCommand()
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: New BugsAssignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Jeff Miller 2011-03-04 14:45:19 PST 
Add WKPageValidateCommand()
Comment 1 Jeff Miller 2011-03-04 15:08:28 PST 
Created attachment 84808 [details]
Patch
Comment 2 Darin Adler 2011-03-04 15:58:19 PST 
Comment on attachment 84808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84808&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:378
> +typedef void (*WKPageValidateCommandCallback)(WKStringRef command, bool isEnabled, int state, WKErrorRef, void*);
> +WK_EXPORT void WKPageValidateCommand(WKPageRef page, WKStringRef command, void* context, WKPageValidateCommandCallback callback);

It’s not clear what “state” is; probably needs a comment. Also, the void* probably needs an argument name to make clear it is the context pointer.
Comment 3 Jeff Miller 2011-03-04 16:59:17 PST 
Committed http://trac.webkit.org/changeset/80394