| Summary: | WebKit+SVG renders full-filters-example incorrectly | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | ian | ||||||||||||
| Priority: | P4 | Keywords: | NeedsReduction | ||||||||||||
| Version: | 523.x (Safari 3) | ||||||||||||||
| Hardware: | Mac | ||||||||||||||
| OS: | OS X 10.4 | ||||||||||||||
| URL: | http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-filters-example-01-b.html | ||||||||||||||
| Bug Depends on: | 4462, 4883, 5526 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Eric Seidel (no email)
2005-11-01 02:45:58 PST
Erick is taking a crack at this one. Created attachment 4684 [details]
patch to fix the clipping problem
This should fix the clipping problem. So what happened is that the input image
was centered at 0,0, but it was supposed to be translated to the (x,y) of the
filter location. This should fix the problem.
Created attachment 4685 [details]
properly patching
Comment on attachment 4685 [details]
properly patching
Erick and I talked about this over IRC. One more round of patch cleanup is
necessary here. Also, there seems to be a stray ASSERT.
Created attachment 4686 [details]
added MacDome's suggestions
Created attachment 4687 [details]
hopefully final patch
Created attachment 4688 [details]
expanded some tabs
Comment on attachment 4688 [details]
expanded some tabs
Looks good. r=me. I'll land this early this week, hopefully as early as
tomorrow.
Comment on attachment 4688 [details]
expanded some tabs
Unfortunately this patch no longer applies cleanly after the big merger. There
still need to be fixes in this area, however this patch is going to need to be
re-worked a bit now. Best if we discuss this over IRC. Removing the review
flag for now.
It actually does a very good job of rendering this example now in TOT, however there are still some clipping issues, which I believe are caused by rounding errors due to our use of ints: http://bugzilla.opendarwin.org/show_bug.cgi?id=4462 Also, this example also suffers from the filter scaling problem: http://bugzilla.opendarwin.org/show_bug.cgi?id=5526 The only thing left "wrong" is the grainyness: http://bugzilla.opendarwin.org/show_bug.cgi?id=5526 Lack of Text: http://bugzilla.opendarwin.org/show_bug.cgi?id=4883 And integer clipping: http://bugzilla.opendarwin.org/show_bug.cgi?id=4462 I'm not sure that this bug serves a lot of use anymore. But I'll leave it for now. Landed in r25175. |