Bug 55789

Summary: Update webkit layout test expectations for Chromium for strict mode
Product: WebKit Reporter: mmaly
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ager, atwilson, commit-queue, dglazkov, mmaly
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   
Attachments:
Description Flags
Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test.
none
Updated test expectations. none

mmaly
Reported 2011-03-04 13:31:47 PST
Update for fast/js/mozilla/strict/15.5.5.1-expected.txt for strict mode features implemented in V8. Strict mode in v8 now correctly throws when assigning to string.length on a string value.
Attachments
Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test. (1.27 KB, text/plain)
2011-03-04 13:33 PST, mmaly 		no flags
Details
Updated test expectations. (1.34 KB, patch)
2011-03-04 13:36 PST, mmaly 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mmaly
Comment 1 2011-03-04 13:33:27 PST
Created attachment 84792 [details] Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test.
mmaly
Comment 2 2011-03-04 13:34:46 PST
Comment on attachment 84792 [details] Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test. Forgot comment.
mmaly
Comment 3 2011-03-04 13:36:32 PST
Created attachment 84793 [details] Updated test expectations.
mmaly
Comment 4 2011-03-04 17:19:49 PST
Comment on attachment 84793 [details] Updated test expectations. Feel free to review but let's not commit this until the chrome test expectations are in. Just committing this could break chrome if this change made it to chrome before the corresponding V8 change.
Dimitri Glazkov (Google)
Comment 5 2011-03-04 18:15:32 PST
Comment on attachment 84793 [details] Updated test expectations. hooray
Adam Barth
Comment 6 2011-03-04 18:19:02 PST
Comment on attachment 84793 [details] Updated test expectations. Clearing commit-queue flag per earlier comment.
mmaly
Comment 7 2011-03-08 08:56:21 PST
The chrome change landed. This is now ready to land as well.
mmaly
Comment 8 2011-03-08 09:08:59 PST
Comment on attachment 84793 [details] Updated test expectations. Ready for commit bots to pick it up. The corresponding Chromium change landed in 77261. http://src.chromium.org/viewvc/chrome?view=rev&revision=77261
Dimitri Glazkov (Google)
Comment 9 2011-03-08 09:40:28 PST
Comment on attachment 84793 [details] Updated test expectations. activate the antimatter reactor.
WebKit Commit Bot
Comment 10 2011-03-08 11:34:12 PST
Comment on attachment 84793 [details] Updated test expectations. Clearing flags on attachment: 84793 Committed r80575: <http://trac.webkit.org/changeset/80575>
WebKit Commit Bot
Comment 11 2011-03-08 11:34:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.