| Summary: | Move shared code into SVGStyledTransformableElement::svgAttributeChanged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | SVG | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, krit, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 55675 | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2011-03-04 06:29:40 PST
Created attachment 84742 [details]
Patch
Comment on attachment 84742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84742&action=review Good catch, please fix the base class call before landing though! If you want cq, please upload a new version. > Source/WebCore/svg/SVGStyledTransformableElement.cpp:86 > + SVGStyledLocatableElement::synchronizeProperty(attrName); Erm, you mean svgAttributeChanged here? Created attachment 84746 [details]
Patch
Comment on attachment 84746 [details]
Patch
r=me.
Comment on attachment 84746 [details] Patch Clearing flags on attachment: 84746 Committed r80362: <http://trac.webkit.org/changeset/80362> All reviewed patches have been landed. Closing bug. SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how? (In reply to comment #7) > SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how? I'd say this is related to the new bug regarding transform + clipPath, we just don't handle it correctly for these elements. |