Bug 55771

Summary: Move shared code into SVGStyledTransformableElement::svgAttributeChanged
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: SVGAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, krit, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 55675    
Attachments:
Description Flags
Patch
zimmermann: review+, zimmermann: commit-queue-
Patch none

Patrick R. Gansterer
Reported 2011-03-04 06:29:40 PST
see patch
Attachments
Patch (10.65 KB, patch)
2011-03-04 06:48 PST, Patrick R. Gansterer 		zimmermann: review+
zimmermann: commit-queue-
DetailsFormatted DiffDiff
Patch (10.65 KB, patch)
2011-03-04 07:24 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-03-04 06:48:28 PST
Created attachment 84742 [details] Patch
Nikolas Zimmermann
Comment 2 2011-03-04 07:18:51 PST
Comment on attachment 84742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84742&action=review Good catch, please fix the base class call before landing though! If you want cq, please upload a new version. > Source/WebCore/svg/SVGStyledTransformableElement.cpp:86 > + SVGStyledLocatableElement::synchronizeProperty(attrName); Erm, you mean svgAttributeChanged here?
Patrick R. Gansterer
Comment 3 2011-03-04 07:24:37 PST
Created attachment 84746 [details] Patch
Nikolas Zimmermann
Comment 4 2011-03-04 07:35:11 PST
Comment on attachment 84746 [details] Patch r=me.
WebKit Commit Bot
Comment 5 2011-03-04 09:38:41 PST
Comment on attachment 84746 [details] Patch Clearing flags on attachment: 84746 Committed r80362: <http://trac.webkit.org/changeset/80362>
WebKit Commit Bot
Comment 6 2011-03-04 09:38:47 PST
All reviewed patches have been landed. Closing bug.
Dirk Schulze
Comment 7 2011-03-04 10:00:52 PST
SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how?
Nikolas Zimmermann
Comment 8 2011-03-05 04:29:49 PST
(In reply to comment #7) > SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how? I'd say this is related to the new bug regarding transform + clipPath, we just don't handle it correctly for these elements.
Note You need to log in before you can comment on or make changes to this bug.