|Summary:||Move shared code into SVGStyledTransformableElement::svgAttributeChanged|
|Product:||WebKit||Reporter:||Patrick R. Gansterer <paroga>|
|Component:||SVG||Assignee:||Patrick R. Gansterer <paroga>|
|Severity:||Normal||CC:||commit-queue, krit, zimmermann|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Patrick R. Gansterer 2011-03-04 06:29:40 PST
Comment 2 Nikolas Zimmermann 2011-03-04 07:18:51 PST
Comment on attachment 84742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84742&action=review Good catch, please fix the base class call before landing though! If you want cq, please upload a new version. > Source/WebCore/svg/SVGStyledTransformableElement.cpp:86 > + SVGStyledLocatableElement::synchronizeProperty(attrName); Erm, you mean svgAttributeChanged here?
Comment 4 Nikolas Zimmermann 2011-03-04 07:35:11 PST
Comment on attachment 84746 [details] Patch r=me.
Comment 5 WebKit Commit Bot 2011-03-04 09:38:41 PST
Comment on attachment 84746 [details] Patch Clearing flags on attachment: 84746 Committed r80362: <http://trac.webkit.org/changeset/80362>
Comment 6 WebKit Commit Bot 2011-03-04 09:38:47 PST
All reviewed patches have been landed. Closing bug.
Comment 7 Dirk Schulze 2011-03-04 10:00:52 PST
SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how?
Comment 8 Nikolas Zimmermann 2011-03-05 04:29:49 PST
(In reply to comment #7) > SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how? I'd say this is related to the new bug regarding transform + clipPath, we just don't handle it correctly for these elements.