Bug 55770

Summary:

Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	pfeldman: review+
Patch for landing	none

Yury Semikhatsky

Reported 2011-03-04 06:03:38 PST

Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation

Attachments
Patch (27.49 KB, patch) 2011-03-04 06:06 PST, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Patch for landing (26.79 KB, patch) 2011-03-04 06:33 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-03-04 06:06:41 PST

Pavel Feldman

Comment 2 2011-03-04 06:20:23 PST

Comment on attachment 84734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84734&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:551 > + domAgent->reset(); setDocument will call reset.

Yury Semikhatsky

Comment 3 2011-03-04 06:33:30 PST

Created attachment 84738 [details] Patch for landing Addressed review comments.

Yury Semikhatsky

Comment 4 2011-03-04 07:16:27 PST

Note You need to log in before you can comment on or make changes to this bug.