Bug 55770 - Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
Summary: Web Inspector: move dispatching of didCommitLoad to agents into InspectorInst...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 54112
  Show dependency treegraph
 
Reported: 2011-03-04 06:03 PST by Yury Semikhatsky
Modified: 2011-03-04 07:16 PST (History)
10 users (show)

See Also:


Attachments
Patch (27.49 KB, patch)
2011-03-04 06:06 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (26.79 KB, patch)
2011-03-04 06:33 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-03-04 06:03:38 PST
Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
Comment 1 Yury Semikhatsky 2011-03-04 06:06:41 PST
Created attachment 84734 [details]
Patch
Comment 2 Pavel Feldman 2011-03-04 06:20:23 PST
Comment on attachment 84734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84734&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:551
> +        domAgent->reset();

setDocument will call reset.
Comment 3 Yury Semikhatsky 2011-03-04 06:33:30 PST
Created attachment 84738 [details]
Patch for landing

Addressed review comments.
Comment 4 Yury Semikhatsky 2011-03-04 07:16:27 PST
Committed r80350: <http://trac.webkit.org/changeset/80350>