Bug 55762

Summary: Web Inspector: [chromium] pause when script is running is broken
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch.
pfeldman: review-
Patch. yurys: review+

Description Pavel Podivilov 2011-03-04 03:38:29 PST 
Web Inspector: [chromium] pause when script is running is broken.
Comment 1 Pavel Podivilov 2011-03-04 03:45:53 PST 
Created attachment 84721 [details]
Patch.
Comment 2 Pavel Feldman 2011-03-04 03:55:14 PST 
Comment on attachment 84721 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84721&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:745
> +    *result = makeString(domain, "_", command);

Please reuse code from dispatch above. Line 712.
Comment 3 Pavel Podivilov 2011-03-04 06:14:18 PST 
Created attachment 84736 [details]
Patch.
Comment 4 Pavel Feldman 2011-03-04 06:24:21 PST 
Comment on attachment 84736 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84736&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:702
> +    HashMap<String, CallHandler>::iterator it = dispatchMap.end();

Declare lower?

> Source/WebCore/inspector/CodeGeneratorInspector.pm:707
>      if (it == dispatchMap.end()) {

else?
Comment 5 Pavel Podivilov 2011-03-04 07:03:32 PST 
Created attachment 84744 [details]
Patch.
Comment 6 Pavel Podivilov 2011-03-05 05:45:39 PST 
Committed r80420: <http://trac.webkit.org/changeset/80420>