Bug 55762

Summary: Web Inspector: [chromium] pause when script is running is broken
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch.
pfeldman: review-
Patch. yurys: review+

Pavel Podivilov
Reported 2011-03-04 03:38:29 PST
Web Inspector: [chromium] pause when script is running is broken.
Attachments
Patch. (1.35 KB, patch)
2011-03-04 03:45 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (4.18 KB, patch)
2011-03-04 06:14 PST, Pavel Podivilov 		pfeldman: review-
DetailsFormatted DiffDiff
Patch. (2.22 KB, patch)
2011-03-04 07:03 PST, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-04 03:45:53 PST
Created attachment 84721 [details] Patch.
Pavel Feldman
Comment 2 2011-03-04 03:55:14 PST
Comment on attachment 84721 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=84721&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:745 > + *result = makeString(domain, "_", command); Please reuse code from dispatch above. Line 712.
Pavel Podivilov
Comment 3 2011-03-04 06:14:18 PST
Created attachment 84736 [details] Patch.
Pavel Feldman
Comment 4 2011-03-04 06:24:21 PST
Comment on attachment 84736 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=84736&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:702 > + HashMap<String, CallHandler>::iterator it = dispatchMap.end(); Declare lower? > Source/WebCore/inspector/CodeGeneratorInspector.pm:707 > if (it == dispatchMap.end()) { else?
Pavel Podivilov
Comment 5 2011-03-04 07:03:32 PST
Created attachment 84744 [details] Patch.
Pavel Podivilov
Comment 6 2011-03-05 05:45:39 PST
Committed r80420: <http://trac.webkit.org/changeset/80420>
Note You need to log in before you can comment on or make changes to this bug.