Bug 55752

Summary: Remove default parameter for compatibility in WebFontInfo::familyForChars()
Product: WebKit Reporter: Takayoshi Kochi <kochi>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jshin, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Remove default parameter for familyForChars(), which is no longer necessary. none

Takayoshi Kochi
Reported 2011-03-04 01:04:24 PST
https://bugs.webkit.org/show_bug.cgi?id=55453 introduced an interface change between Chromium and WebKit, and for maintaining compatibility, WebFontInfo::familyForChars()'s 3rd parameter is declared as a default parameter (preferredLocale = 0). Once Chromium side of changes are complete, remove the default parameter.
Attachments
Remove default parameter for familyForChars(), which is no longer necessary. (1.29 KB, patch)
2011-03-10 00:56 PST, Takayoshi Kochi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takayoshi Kochi
Comment 1 2011-03-10 00:56:14 PST
Created attachment 85293 [details] Remove default parameter for familyForChars(), which is no longer necessary.
Takayoshi Kochi
Comment 2 2011-03-10 01:16:18 PST
Tony, Could you please review and commit if this looks good? This is a clean up of remaining stuff in https://bugs.webkit.org/show_bug.cgi?id=55453 Thanks!
WebKit Commit Bot
Comment 3 2011-03-10 20:44:51 PST
Comment on attachment 85293 [details] Remove default parameter for familyForChars(), which is no longer necessary. Clearing flags on attachment: 85293 Committed r80810: <http://trac.webkit.org/changeset/80810>
WebKit Commit Bot
Comment 4 2011-03-10 20:44:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.