| Summary: | add webkit-patch post-attachment for posting to bugzilla from the commandline | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, noel.gordon | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ojan Vafai
2011-03-03 23:51:15 PST
Created attachment 84701 [details]
Patch
Don't you want this as post-patch since it assumes it's a patch? You could do a post-attachment and have it use the attachment paths instead of the patch ones. Created attachment 84706 [details]
Patch
Comment on attachment 84706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review > Tools/Scripts/webkitpy/tool/commands/upload.py:178 > + help_text = "Attach the the file to the bug as a patch file" This doens't just do patches, right? This should handle other mime types just fine, or? (In reply to comment #2) > Don't you want this as post-patch since it assumes it's a patch? You could do a post-attachment and have it use the attachment paths instead of the patch ones. I don't understand. Where is it assuming it's a patch? I specifically want post-attachment. We could add flags for marking for review/commit-queue to post-attachment as well if there's a use-case for posting patch files. (In reply to comment #4) > (From update of attachment 84706 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review > > > Tools/Scripts/webkitpy/tool/commands/upload.py:178 > > + help_text = "Attach the the file to the bug as a patch file" > > This doens't just do patches, right? This should handle other mime types just fine, or? Whoops. That's just a copy-paste typo. Will change it to "Attach the the file to the bug" Comment on attachment 84706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review My only concern is this command getting confused with the "post" command. Maybe "attach-to-bug" ? webkit-patch attach-to-bug 23983 foo.patch > Tools/Scripts/webkitpy/tool/commands/upload.py:179 > + argument_names = "BUGID FILEPATH [\"DESCRIPTION\"]" Normally, we used -m for the description, right? > Tools/Scripts/webkitpy/tool/commands/upload.py:-207 > - This removal seems spurious and incorrect. Committed r80537: <http://trac.webkit.org/changeset/80537> |