Bug 55738

Summary: Get rid of Page::globalHistoryItem
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2011-03-03 18:44:35 PST
Get rid of Page::globalHistoryItem
Attachments
Patch (17.95 KB, patch)
2011-03-03 18:48 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-03-03 18:48:41 PST
Created attachment 84678 [details] Patch
WebKit Review Bot
Comment 2 2011-03-03 18:51:20 PST
Attachment 84678 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/mac/WebView/WebViewData.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2011-03-03 19:21:14 PST
Committed r80310: <http://trac.webkit.org/changeset/80310>
WebKit Review Bot
Comment 4 2011-03-03 20:10:06 PST
http://trac.webkit.org/changeset/80310 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: accessibility/plugin.html compositing/geometry/empty-embed-rects.html fast/loader/loadInProgress.html
Note You need to log in before you can comment on or make changes to this bug.