WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55738
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
Summary
Get rid of Page::globalHistoryItem
Anders Carlsson
Reported
Friday, March 4, 2011 2:44:35 AM UTC
Get rid of Page::globalHistoryItem
Attachments
Patch
(17.95 KB, patch)
2011-03-03 18:48 PST
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
Friday, March 4, 2011 2:48:41 AM UTC
Created
attachment 84678
[details]
Patch
WebKit Review Bot
Comment 2
Friday, March 4, 2011 2:51:20 AM UTC
Attachment 84678
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/mac/WebView/WebViewData.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
Friday, March 4, 2011 3:21:14 AM UTC
Committed
r80310
: <
http://trac.webkit.org/changeset/80310
>
WebKit Review Bot
Comment 4
Friday, March 4, 2011 4:10:06 AM UTC
http://trac.webkit.org/changeset/80310
might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: accessibility/plugin.html compositing/geometry/empty-embed-rects.html fast/loader/loadInProgress.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug