Bug 55738 - Get rid of Page::globalHistoryItem
Summary: Get rid of Page::globalHistoryItem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 18:44 PST by Anders Carlsson
Modified: 2011-03-03 20:10 PST (History)
3 users (show)

See Also:

Attachments
Patch (17.95 KB, patch)
2011-03-03 18:48 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-03-03 18:44:35 PST 
Get rid of Page::globalHistoryItem
Comment 1 Anders Carlsson 2011-03-03 18:48:41 PST 
Created attachment 84678 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-03 18:51:20 PST 
Attachment 84678 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/mac/WebView/WebViewData.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2011-03-03 19:21:14 PST 
Committed r80310: <http://trac.webkit.org/changeset/80310>
Comment 4 WebKit Review Bot 2011-03-03 20:10:06 PST 
http://trac.webkit.org/changeset/80310 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
accessibility/plugin.html
compositing/geometry/empty-embed-rects.html
fast/loader/loadInProgress.html