Bug 55726

Summary:

Enable fullscreen layout tests for Chromium

Product:

WebKit

Reporter:

David Dorwin <ddorwin>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddorwin, levin, scherkus

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

44797, 55727

Bug Blocks:

Attachments:

Description	Flags
Enable fullscreen in Chromium's DumpRenderTree.	none
Remove test_expectations entry for fullscreen tests.	none
Fixed typo.	none
Merged with head	none
Merged with head	none

Description David Dorwin 2011-03-03 16:47:59 PST

The fullscreen layout tests have been failing in Chromium since they were landed. The fullscreen API is enabled for Chromium WebKit (bug 44797) and is about to be compiled but disabled by default for Chromium. This bug replaces bug 44797 for tracking the test_expectations.txt override for the fullscreen tests.

Once the fullscreen API is enabled by default in Chromium, we can remove the entry(ies) from test_expectations.txt.

Comment 1 David Dorwin 2011-03-29 17:22:09 PDT

Created attachment 87439 [details]
Enable fullscreen in Chromium's DumpRenderTree.

Enable fullscreen in DumpRenderTree by default so we can enable the the fullscreen tests before the feature is enabled by default in Chromium. This is similar to what was done for the mac platform.

Comment 2 David Dorwin 2011-03-30 14:25:38 PDT

Created attachment 87614 [details]
Remove test_expectations entry for fullscreen tests.

There is a Chromium entry overriding this, and we should be able to remove it once this changeset as well as bug 57400 and 57483 are committed.

Comment 3 David Levin 2011-04-04 12:01:45 PDT

Comment on attachment 87614 [details]
Remove test_expectations entry for fullscreen tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=87614&action=review

> Tools/DumpRenderTree/chromium/WebPreferences.cpp:169
> +    // Enable fullscreen so the fullscreen LaoutTests can run.

typo: LaoutTests

Comment 4 David Levin 2011-04-04 13:00:04 PDT

Note that even though you are not a committer you can take advantage of this r+. Just fix the issue and change the ChangeLog to say "Review by David Levin." (instead of the OOPS thing).

Then upload a new patch and don't mark it r?. You may want to mark it as cq?
Just any committer to make it as cq+ (and you have a few around you) and it will go through.

Comment 5 David Dorwin 2011-04-04 14:29:29 PDT

Created attachment 88130 [details]
Fixed typo.

Comment 6 David Dorwin 2011-04-04 17:03:19 PDT

Created attachment 88165 [details]
Merged with head

Comment 7 David Dorwin 2011-04-06 13:45:11 PDT

Created attachment 88503 [details]
Merged with head

Comment 8 WebKit Commit Bot 2011-04-06 15:37:27 PDT

Comment on attachment 88503 [details]
Merged with head

Clearing flags on attachment: 88503

Committed r83112: <http://trac.webkit.org/changeset/83112>

Comment 9 WebKit Commit Bot 2011-04-06 15:37:35 PDT

All reviewed patches have been landed.  Closing bug.