Bug 55702

Summary:

Scrubbing <video> with HTTP Live Stream resizes element to 0x0

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, simon.fraser

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

URL:

http://events.apple.com.edgesuite.net/1103pijanbdvaaj/event/index.html

Attachments:

Description	Flags
Patch	simon.fraser: review+

Jer Noble

Reported 2011-03-03 13:14:22 PST

Scrubbing the iPad2 - march 2 event keynote video in Safari on Snow Leopard kills video presentation.

Attachments
Patch (3.73 KB, patch) 2011-03-03 13:59 PST, Jer Noble	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2011-03-03 13:14:36 PST

<rdar://problem/9078563>

Jer Noble

Comment 2 2011-03-03 13:59:14 PST

Created attachment 84620 [details] Patch

Simon Fraser (smfr)

Comment 3 2011-03-03 14:06:42 PST

Comment on attachment 84620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review > Source/WebCore/ChangeLog:9 > + a HTTP Live Stream. So we will cache the last valid value returned by QTKit "an HTTP Live Stream"? > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211 > + FloatSize m_cachedNaturalSize; You could make this mutable. > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232 > + , m_cachedNaturalSize(FloatSize()) No need to initialize; FloatSize has its own ctor.

Jer Noble

Comment 4 2011-03-03 15:15:27 PST

(In reply to comment #3) > (From update of attachment 84620 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review > > > Source/WebCore/ChangeLog:9 > > + a HTTP Live Stream. So we will cache the last valid value returned by QTKit > > "an HTTP Live Stream"? http://owl.english.purdue.edu/owl/resource/540/01/ I guess it depends on whether you pronounce it "aich tee tee pee" or "haich tee tee pee". :-D > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211 > > + FloatSize m_cachedNaturalSize; > > You could make this mutable. Fantastic idea. > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232 > > + , m_cachedNaturalSize(FloatSize()) > > No need to initialize; FloatSize has its own actor. Sure. Thanks!

Jer Noble

Comment 5 2011-03-23 17:59:49 PDT

Committed r81833: <http://trac.webkit.org/changeset/81833>

Note You need to log in before you can comment on or make changes to this bug.