Bug 55698

Summary: JSVariableObject needs to use WriteBarrier for symboltable property storage
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2011-03-03 12:24:35 PST
JSVariableObject needs to use WriteBarrier for symboltable property storage
Attachments
Patch (44.69 KB, patch)
2011-03-03 12:33 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-03 12:33:25 PST
Created attachment 84608 [details] Patch
Darin Adler
Comment 2 2011-03-03 12:34:18 PST
Comment on attachment 84608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84608&action=review > Source/JavaScriptCore/runtime/ArgList.h:75 > - m_buffer = buffer; > + m_buffer = reinterpret_cast<Register*>(buffer); Why is this OK?
Oliver Hunt
Comment 3 2011-03-03 12:36:32 PST
(In reply to comment #2) > (From update of attachment 84608 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84608&action=review > > > Source/JavaScriptCore/runtime/ArgList.h:75 > > - m_buffer = buffer; > > + m_buffer = reinterpret_cast<Register*>(buffer); > > Why is this OK? Register is just another class that wraps a JSValue, which is (essentially) all that WriteBarrier is
Geoffrey Garen
Comment 4 2011-03-03 13:27:53 PST
Comment on attachment 84608 [details] Patch r=me
Oliver Hunt
Comment 5 2011-03-03 14:31:29 PST
Committed r80285: <http://trac.webkit.org/changeset/80285>
Note You need to log in before you can comment on or make changes to this bug.