| Summary: | Many tests fail in WebKit2 mode on Windows due to incorrect parsing of absolute Windows-style file: URLs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric.carlson, eric, jer.noble, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| URL: | http://build.webkit.org/results/Windows%207%20Release%20%28WebKit2%20Tests%29/r80235%20(3670)/results.html | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-03-03 07:21:32 PST
Just looking at media/audio-constructor-preload.html, I see HTMLMediaElement::scheduleLoad get called, but the load timer never fires. Even though the timer doesn't fire, HTMLMediaElement::load is getting called by JS, so the load is starting. But it looks like we're getting a bogus URL: file://c/Documents%20and%20Settings/Adam%20Roben/dev/WebKit/OpenSource/LayoutTests/media/content/test.wav Note the missing colon after "file://c". I think this is actually the root cause of a lot of test failures in WebKit2 on Windows. Just to close the loop on the timer issue: HTMLMediaElement::load is canceling the timer, since the load is now happening synchronously. Document::m_baseURL is also missing the colon. As is Document::m_documentURI. KURL::parse is getting passed this: file://c:/Documents and Settings/Adam Roben/dev/WebKit/OpenSource/LayoutTests/media/audio-constructor-preload.html It parses the colon in "c:" as introducing a port number. But then there is no port number so it continues on its merry way, and "c" gets set as the host. Clearly KURL is buggy with respect to absolute Windows-style file: URLs. DRT on Windows used CFURL to convert the path into a URL. I have a workaround. I'll file a new bug for the underlying KURL issue. Created attachment 84574 [details]
Work around a bug in KURL's parsing of Windows-style absolute file: URLs
Committed r80249: <http://trac.webkit.org/changeset/80249> http://trac.webkit.org/changeset/80249 might have broken Windows 7 Release (Tests) The following tests are not passing: animations/combo-transform-rotate+scale.html animations/keyframe-timing-functions-transform.html inspector/extensions/extensions-audits.html |