| Summary: | Allow to use PLATFORM(...) defines in *.messages.in and ifdef related headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oleg Romashin (:romaxa) <romaxa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abecsi, andersca, buildbot, commit-queue, webkit-ews, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 55719 | ||
| Attachments: | |||
Created attachment 84536 [details]
Sorry for my python, but this seems to work fine and fix the problem
Attachment 84536 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Scripts/webkit2/messages.py:452: missing whitespace after ':' [pep8/E231] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 84536 [details] did not build on qt: Build output: http://queues.webkit.org/results/8086165 Attachment 84536 [details] did not build on win: Build output: http://queues.webkit.org/results/8084343 Created attachment 84648 [details]
One more try, No array hacks, fixed style
Attachment 84648 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Scripts/webkit2/messages.py:452: whitespace after '{' [pep8/E201] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 84660 [details]
Fixed style (finally make style script working in my environment)
Any chance to get this patch reviewed? Created attachment 86024 [details]
Fixed minor bug, and updated unittest
Attachment 86024 [details] did not build on qt: Build output: http://queues.webkit.org/results/8189410 Attachment 86024 [details] did not build on win: Build output: http://queues.webkit.org/results/8191387 Created attachment 86027 [details]
Fixed build problem
Fixed another problem, when messageX ifdefed causing headerX, and messageY non-ifdefed causing headerX, then we should not put headerX into ifdef condition
Comment on attachment 86027 [details]
Fixed build problem
yep, this compiles now fine
The commit-queue encountered the following flaky tests while processing attachment 86027 [details]: http/tests/cache/history-only-cached-subresource-loads.html bug 56567 (author: joepeck@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 86027 [details] Fixed build problem Clearing flags on attachment: 86027 Committed r81362: <http://trac.webkit.org/changeset/81362> All reviewed patches have been landed. Closing bug. |
Attempt to compile Qt port with ENABLE_PLUGIN_PROCESS failed with message: -I../include/WebKit2 -I/usr/src/3rdparty/sqlite/ -I/usr/X11R6/include -I. -I../../../WebKit/Source/WebKit2 -I. -o obj/debug/WebDatabaseManagerMessageReceiver.o generated/WebDatabaseManagerMessageReceiver.cpp generated/PluginProcessProxyMessageReceiver.cpp:34:22: error: MachPort.h: No such file or directory Attempt to ifdef #if PLATFORM(MAC) DidCreateWebProcessConnection(CoreIPC::MachPort connectionIdentifier) #endif in PluginProcessProxy.messages.in does fix the problem, because messages.py ignore those ifdefs