Bug 55653 – Moved all variable object storage inline -- upping the object size limit to 1K

• Component: New Bugs
• Status: RESOLVED FIXED

[Geoffrey Garen]

Moved all variable object storage inline -- upping the object size limit to 1K

[Geoffrey Garen]

Created attachment 84527 [details]
Patch

[Early Warning System Bot]

Attachment 84527 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8077984

[Build Bot]

Attachment 84527 [details] did not build on win:
Build output: http://queues.webkit.org/results/8084329

[Darin Adler]

Comment on attachment 84527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84527&action=review

Please make sure to fix the Qt and Windows builds. Both are failing on the EWS bots.

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:81
> +        Event* m_evt;

Can this be named m_event instead? Why abbreviate event to "evt".

[Geoffrey Garen]

Committed r80277: <http://trac.webkit.org/changeset/80277>

[WebKit Review Bot]

http://trac.webkit.org/changeset/80277 might have broken Qt Windows 32-bit Debug

[Martin Robinson]

This commit seems to have caused many test failures on GTK+:  http://build.webkit.org/results/GTK Linux 64-bit Debug/r80284 (19987)/results.html

I also see many new failures on Intel Release (Tests): http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r80285%20(29135) Though I'm not sure if they are related or not.

I have confirmed that at least some of these tests started failing right ater this commit.

[Geoffrey Garen]

Rolled out in http://trac.webkit.org/changeset/80303.

[Geoffrey Garen]

Also caused a performance regression on Kraken: bug 55729.

[Geoffrey Garen]

Created attachment 85357 [details]
Patch

[Geoffrey Garen]

Committed r80742: <http://trac.webkit.org/changeset/80742>