Bug 55646

Summary:

Fix location of assert

Product:

WebKit

Reporter:

David Grogan <dgrogan>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

jorlow

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	levin: review-

David Grogan

Reported 2011-03-02 19:32:43 PST

Fix location of assert

Attachments
Patch (1.32 KB, patch) 2011-03-02 19:33 PST, David Grogan	levin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Grogan

Comment 1 2011-03-02 19:33:09 PST

Created attachment 84512 [details] Patch

Darin Adler

Comment 2 2011-03-02 20:04:47 PST

Comment on attachment 84512 [details] Patch Did the assertion fire in some case? If so, can we check in a test case that shows the failure?

Jeremy Orlow

Comment 3 2011-03-02 20:40:47 PST

(In reply to comment #2) > (From update of attachment 84512 [details]) > Did the assertion fire in some case? If so, can we check in a test case that shows the failure? It fired on one of our tests occasionally. It was always supposed to be below the scriptExecutionContext() test but accidentally was placed incorrectly (I think during some refactoring...because I always meant for it to be above). Off the top of my head, I'm not actually sure how we could deterministically cause it to fire. How much do you care about trying to create a test for it?

Jeremy Orlow

Comment 4 2011-03-02 21:14:02 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 84512 [details] [details]) > > Did the assertion fire in some case? If so, can we check in a test case that shows the failure? > > It fired on one of our tests occasionally. It was always supposed to be below the scriptExecutionContext() test but accidentally was placed incorrectly (I think during some refactoring...because I always meant for it to be above). Off the top of my head, I'm not actually sure how we could deterministically cause it to fire. > > How much do you care about trying to create a test for it? Actually, I take that back. I think we should try to construct a test for this. But David is OOO for the next couple days and I'd like to get this in. Are you OK with this going in if I create a bug for a test to be created?

David Levin

Comment 5 2011-04-06 13:36:20 PDT

Comment on attachment 84512 [details] Patch Add test (or explain why it can't be done).

David Grogan

Comment 6 2012-02-10 15:11:09 PST

Obsolete.

Note You need to log in before you can comment on or make changes to this bug.