Bug 55627

Summary: Manually revert ChromiumDataObject changes.
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Daniel Cheng
Reported 2011-03-02 16:16:13 PST
Manually revert ChromiumDataObject changes.
Attachments
Patch (27.49 KB, patch)
2011-03-02 16:16 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (27.49 KB, patch)
2011-03-02 16:49 PST, Daniel Cheng 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2011-03-02 16:16:46 PST
Created attachment 84481 [details] Patch
WebKit Review Bot
Comment 2 2011-03-02 16:19:50 PST
Attachment 84481 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/platform/chromium/ChromiumDataObject.h:46: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2011-03-02 16:33:36 PST
Attachment 84481 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8086037
Daniel Cheng
Comment 4 2011-03-02 16:49:50 PST
Created attachment 84487 [details] Patch
WebKit Review Bot
Comment 5 2011-03-02 16:53:49 PST
Attachment 84487 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/platform/chromium/ChromiumDataObject.h:46: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Cheng
Comment 6 2011-03-02 17:00:54 PST
Committed r80185: <http://trac.webkit.org/changeset/80185>
Note You need to log in before you can comment on or make changes to this bug.