| Summary: | Manually revert ChromiumDataObject changes. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Cheng <dcheng> | ||||||
| Component: | New Bugs | Assignee: | Daniel Cheng <dcheng> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Cheng
2011-03-02 16:16:13 PST
Created attachment 84481 [details]
Patch
Attachment 84481 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/platform/chromium/ChromiumDataObject.h:46: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 84481 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8086037 Created attachment 84487 [details]
Patch
Attachment 84487 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/platform/chromium/ChromiumDataObject.h:46: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r80185: <http://trac.webkit.org/changeset/80185> |