Bug 55623

Summary: Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit2Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, buildbot, sam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change
darin: review+, timothy: commit-queue-
Proposed Tools Change darin: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2011-03-02 15:13:00 PST
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef instead of a WKStringRef.
Attachments
Proposed Change (14.22 KB, patch)
2011-03-02 15:20 PST, Timothy Hatcher 		darin: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Proposed Tools Change (5.69 KB, patch)
2011-03-03 16:43 PST, Timothy Hatcher 		darin: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2011-03-02 15:20:14 PST
Created attachment 84476 [details] Proposed Change
Timothy Hatcher
Comment 2 2011-03-02 17:23:33 PST
Landed in r80188.
Timothy Hatcher
Comment 3 2011-03-03 16:43:28 PST
Created attachment 84655 [details] Proposed Tools Change
Timothy Hatcher
Comment 4 2011-03-03 16:46:31 PST
Reopend to track fixing the tests and relanding after a roll out.
Darin Adler
Comment 5 2011-03-03 16:46:49 PST
Comment on attachment 84655 [details] Proposed Tools Change Looks fine.
Build Bot
Comment 6 2011-03-03 20:53:06 PST
Attachment 84655 [details] did not build on win: Build output: http://queues.webkit.org/results/8078826
Timothy Hatcher
Comment 7 2011-03-03 21:25:08 PST
Adam, any tips why this fails to build on Windows?
Timothy Hatcher
Comment 8 2011-03-04 08:39:41 PST
I forgot the tools patch didn't have the main changes to WebKit2, so it wouldn't build.
Timothy Hatcher
Comment 9 2011-03-04 09:52:11 PST
http://trac.webkit.org/changeset/80358
Note You need to log in before you can comment on or make changes to this bug.