Summary: | Expose ability to create instance of DOMFileSystem from Chromium side | ||
---|---|---|---|
Product: | WebKit | Reporter: | Zelidrag Hornung <zelidrag> |
Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Enhancement | CC: | commit-queue, ericu, fishd, kinuko, levin |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | Other | ||
Attachments: |
Description
Zelidrag Hornung
2011-03-02 14:43:24 PST
Created attachment 84471 [details]
Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side.
For the lack of better place, I've added this new method as:
WebKit::WebFrame::createFileSystem(int type, const WebString& name, const WebString& path)
Please advise if this should live somewhere else instead.
Comment on attachment 84471 [details] Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side. The patch seems to include unrelated LayoutTests files (and they don't look really changed -- maybe end-of-line issues?). Can you get rid of them? I believe this change needs Darin's review. View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review > Source/WebKit/chromium/ChangeLog:3 > + Reviewed by Eric Uhrhane. The reviewer line should be filled after this patch gets reviewed. Comment on attachment 84471 [details] Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side. View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review > Source/WebKit/chromium/ChangeLog:4 > + Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you. Incidentally, I'm not a webkit reviewer. I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs. (In reply to comment #3) > (From update of attachment 84471 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review > > > Source/WebKit/chromium/ChangeLog:4 > > + > > Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you. > > Incidentally, I'm not a webkit reviewer. I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs. ...except that Darin's out on leave for a bit. Another reviewer will have to do. Created attachment 84658 [details]
fixed comments in ChangeLog
fixed comments in ChangeLog
Comment on attachment 84471 [details] Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side. View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review >> Source/WebKit/chromium/ChangeLog:3 > > The reviewer line should be filled after this patch gets reviewed. fixed >>> Source/WebKit/chromium/ChangeLog:4 >> >> Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you. >> >> Incidentally, I'm not a webkit reviewer. I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs. > > ...except that Darin's out on leave for a bit. Another reviewer will have to do. fixed Comment on attachment 84658 [details]
fixed comments in ChangeLog
r- to fix nits (as noted), so I can cq+ the next version of the patch.
Created attachment 84661 [details]
fixed nits from levin's feedback
fixed nits from levin's feedback
Comment on attachment 84661 [details] fixed nits from levin's feedback Clearing flags on attachment: 84661 Committed r80333: <http://trac.webkit.org/changeset/80333> All reviewed patches have been landed. Closing bug. |