| Summary: | fast/block/positioning/offsetLeft-offsetTop-borders.html doesn't need to be a pixel test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Moskovich <playmobil> | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, eric, koivisto, rniwa, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Jeremy Moskovich
2011-03-02 13:48:26 PST
Created attachment 84460 [details]
Patch
Comment on attachment 84460 [details]
Patch
Sounds reasonable. Can you also remove the minuses dashing across the screen?
(In reply to comment #2) > (From update of attachment 84460 [details]) > Sounds reasonable. Can you also remove the minuses dashing across the screen? OTOH, dashes help visually. No worries. Comment on attachment 84460 [details]
Patch
Per offline discussion with dglazkov, the dashes are a visual aide so leaving them in. If anyone feels strongly on the subject, feel free to remove them in a separate patch.
The commit-queue encountered the following flaky tests while processing attachment 84460 [details]: http/tests/plugins/cross-frame-object-access.html bug 54791 (author: andersca@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 84460 [details] Patch Clearing flags on attachment: 84460 Committed r80223: <http://trac.webkit.org/changeset/80223> All reviewed patches have been landed. Closing bug. |