Bug 55612

Summary: fast/block/positioning/offsetLeft-offsetTop-borders.html doesn't need to be a pixel test
Product: WebKit Reporter: Jeremy Moskovich <playmobil>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, koivisto, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jeremy Moskovich
Reported 2011-03-02 13:48:26 PST
fast/block/positioning/offsetLeft-offsetTop-borders.html outputs the values of offsetLeft/offsetTop for part of the DOM, if I'm not mistaken this doesn't need to be a pixel test.
Attachments
Patch (86.87 KB, patch)
2011-03-02 13:55 PST, Jeremy Moskovich 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2011-03-02 13:55:25 PST
Created attachment 84460 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-02 15:01:15 PST
Comment on attachment 84460 [details] Patch Sounds reasonable. Can you also remove the minuses dashing across the screen?
Dimitri Glazkov (Google)
Comment 3 2011-03-02 15:29:14 PST
(In reply to comment #2) > (From update of attachment 84460 [details]) > Sounds reasonable. Can you also remove the minuses dashing across the screen? OTOH, dashes help visually. No worries.
Jeremy Moskovich
Comment 4 2011-03-02 15:30:31 PST
Comment on attachment 84460 [details] Patch Per offline discussion with dglazkov, the dashes are a visual aide so leaving them in. If anyone feels strongly on the subject, feel free to remove them in a separate patch.
WebKit Commit Bot
Comment 5 2011-03-03 02:56:30 PST
The commit-queue encountered the following flaky tests while processing attachment 84460 [details]: http/tests/plugins/cross-frame-object-access.html bug 54791 (author: andersca@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-03-03 02:58:50 PST
Comment on attachment 84460 [details] Patch Clearing flags on attachment: 84460 Committed r80223: <http://trac.webkit.org/changeset/80223>
WebKit Commit Bot
Comment 7 2011-03-03 02:58:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.