Bug 55602

Summary: REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, hyatt, mitz, sam, simon.fraser
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80149%20(15273)/DumpRenderTree2-leaks.txt
Bug Depends on:    
Bug Blocks: 55611    
Attachments:
Description Flags
Patch none

Description Adam Roben (:aroben) 2011-03-02 12:34:31 PST
The SnowLeopard Intel Leaks bot is showing lots of leaks of FloatingObjects. See the URL for an example.

Maybe this is related to the recent work done in this area in r79817 and r79834?
Comment 1 Adam Roben (:aroben) 2011-03-02 12:35:00 PST
<rdar://problem/9076342>
Comment 4 Benjamin Poulain 2011-03-02 12:41:08 PST
It is probably my fault. I have probably forgot at delete when the object are removed from the list.

You can assign to me, I can have a look on Saturday.
Comment 5 Benjamin Poulain 2011-03-02 13:52:37 PST
Created attachment 84459 [details]
Patch
Comment 6 Benjamin Poulain 2011-03-02 13:56:27 PST
I went over all the call removing objects of m_floatingObjects and found an instance were I forgot to call deleteAllValues().

I created https://bugs.webkit.org/show_bug.cgi?id=55611 to look for a better way to handle memory so we have a long term solution.
Comment 7 WebKit Commit Bot 2011-03-03 02:44:55 PST
Comment on attachment 84459 [details]
Patch

Clearing flags on attachment: 84459

Committed r80221: <http://trac.webkit.org/changeset/80221>
Comment 8 WebKit Commit Bot 2011-03-03 02:45:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Adam Roben (:aroben) 2011-03-03 05:46:09 PST
Great! Leaks went from 12434 in r80218:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15291

…to 10964 in r80226:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15292

Thanks, Benjamin!