Bug 55602

Summary:

REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Layout and Rendering

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, hyatt, mitz, sam, simon.fraser

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

URL:

http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80149%20(15273)/DumpRenderTree2-leaks.txt

Bug Depends on:

Bug Blocks:

55611

Attachments:

Description	Flags
Patch	none

Adam Roben (:aroben)

Reported 2011-03-02 12:34:31 PST

The SnowLeopard Intel Leaks bot is showing lots of leaks of FloatingObjects. See the URL for an example. Maybe this is related to the recent work done in this area in r79817 and r79834?

Attachments
Patch (1.68 KB, patch) 2011-03-02 13:52 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-03-02 12:35:00 PST

<rdar://problem/9076342>

Adam Roben (:aroben)

Comment 2 2011-03-02 12:36:35 PST

The number of leaks jumped from 409 in r79816: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15177 ...to 3641 in r79817: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15178

Adam Roben (:aroben)

Comment 3 2011-03-02 12:39:14 PST

r79834 seems to have had no effect on the number of leaks: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15186 http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15187

Benjamin Poulain

Comment 4 2011-03-02 12:41:08 PST

It is probably my fault. I have probably forgot at delete when the object are removed from the list. You can assign to me, I can have a look on Saturday.

Benjamin Poulain

Comment 5 2011-03-02 13:52:37 PST

Created attachment 84459 [details] Patch

Benjamin Poulain

Comment 6 2011-03-02 13:56:27 PST

I went over all the call removing objects of m_floatingObjects and found an instance were I forgot to call deleteAllValues(). I created https://bugs.webkit.org/show_bug.cgi?id=55611 to look for a better way to handle memory so we have a long term solution.

WebKit Commit Bot

Comment 7 2011-03-03 02:44:55 PST

Comment on attachment 84459 [details] Patch Clearing flags on attachment: 84459 Committed r80221: <http://trac.webkit.org/changeset/80221>

WebKit Commit Bot

Comment 8 2011-03-03 02:45:00 PST

All reviewed patches have been landed. Closing bug.

Adam Roben (:aroben)

Comment 9 2011-03-03 05:46:09 PST

Great! Leaks went from 12434 in r80218: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15291 …to 10964 in r80226: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15292 Thanks, Benjamin!

Note You need to log in before you can comment on or make changes to this bug.