Bug 55599

Summary:

r80079 caused incremental Windows builds to fail

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dcheng, sfalken

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch	tony: review+

Description Adam Roben (:aroben) 2011-03-02 12:01:22 PST

r80079 caused incremental Windows builds to fail

Comment 1 Adam Roben (:aroben) 2011-03-02 12:02:19 PST

Here's the build that failed: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/31688

The errors were:

10>WebKit2WebProcess.res : fatal error LNK1241: resource file WebKit2WebProcess.res already specified
11>FindSafari.res : fatal error LNK1241: resource file FindSafari.res already specified

Comment 2 Adam Roben (:aroben) 2011-03-02 12:02:48 PST

Created attachment 84445 [details]
Patch

Comment 3 Tony Chang 2011-03-02 12:43:38 PST

Comment on attachment 84445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84445&action=review

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:24
> +    for extension in ['manifest', 'pch', 'res']:

Nit: Using a tuple instead of a list is a bit more efficient.

Comment 4 Adam Roben (:aroben) 2011-03-02 12:49:40 PST

Committed r80158: <http://trac.webkit.org/changeset/80158>