Bug 55575

Summary: Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Pavel Feldman
Reported 2011-03-02 07:15:59 PST
Patch to follow.
Attachments
Patch (35.77 KB, patch)
2011-03-02 07:17 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (35.79 KB, patch)
2011-03-02 09:22 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-02 07:17:39 PST
Created attachment 84416 [details] Patch
Yury Semikhatsky
Comment 2 2011-03-02 07:23:09 PST
Comment on attachment 84416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84416&action=review > Source/WebCore/inspector/InspectorRuntimeAgent.cpp:57 > + InjectedScript injectedScript = m_injectedScriptHost->injectedScriptForMainFrame(); Injected script where the objectId was created should be used instead. r- for this.
Yury Semikhatsky
Comment 3 2011-03-02 07:28:17 PST
Comment on attachment 84416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84416&action=review > Source/WebCore/inspector/InspectorDOMAgent.h:62 > +class ScriptValue; Remove this? > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:426 > + function resolvedNode(objectPayload) resolvedNode -> didResolveNode?
Pavel Feldman
Comment 4 2011-03-02 09:22:14 PST
Created attachment 84425 [details] Patch
Pavel Feldman
Comment 5 2011-03-02 09:40:14 PST
Committed r80141: <http://trac.webkit.org/changeset/80141>
Note You need to log in before you can comment on or make changes to this bug.