| Summary: | [Chrome][DRT] Should roll Chromium revision up to r76362 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, tkent, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 55434 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hajime Morrita
2011-03-02 03:03:22 PST
(In reply to comment #0) > which requires build bot reboots. Do you mean 'clobber', not 'reboot'? Created attachment 84396 [details]
Patch
Attachment 84396 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8072970 We need to add an entry for libjpeg_turbo to DEPS, don't we? Also, please make sure you can build Chromium port with WebKit-only checkout and your patch. I'll take a stab at this. I'm able to ssh to the bots and clobber them. Created attachment 84467 [details]
Patch
Comment on attachment 84467 [details]
Patch
This works on my Linux machine. I will try to land it this afternoon. I don't think we need a clobber.
http://trac.webkit.org/changeset/80174 It passed on win and linux. I'm still waiting for mac to finish cycling. Hi Tony, Thank you for your help! I thought we need the clobber the build, just because chromium builds did need it. But I don't know why. So if it can go without clobber, it's fine. |