Bug 55564

Summary: [Chrome][DRT] Should roll Chromium revision up to r76362
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55434    
Attachments:
Description Flags
Patch
none
Patch none

Hajime Morrita
Reported 2011-03-02 03:03:22 PST
To use a new webkit_support API, DRT needs new revision of Chromium tree. Note that the change will contain icu4.6 and libjpeg_turbo, which requires build bot reboots.
Attachments
Patch (2.28 KB, patch)
2011-03-02 03:50 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2011-03-02 14:25 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-03-02 03:19:48 PST
(In reply to comment #0) > which requires build bot reboots. Do you mean 'clobber', not 'reboot'?
Hajime Morrita
Comment 2 2011-03-02 03:50:47 PST
Created attachment 84396 [details] Patch
WebKit Review Bot
Comment 3 2011-03-02 04:06:26 PST
Attachment 84396 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8072970
Kent Tamura
Comment 4 2011-03-02 05:49:20 PST
We need to add an entry for libjpeg_turbo to DEPS, don't we? Also, please make sure you can build Chromium port with WebKit-only checkout and your patch.
Tony Chang
Comment 5 2011-03-02 13:55:50 PST
I'll take a stab at this. I'm able to ssh to the bots and clobber them.
Tony Chang
Comment 6 2011-03-02 14:25:01 PST
Created attachment 84467 [details] Patch
Tony Chang
Comment 7 2011-03-02 14:25:30 PST
Comment on attachment 84467 [details] Patch This works on my Linux machine. I will try to land it this afternoon. I don't think we need a clobber.
Tony Chang
Comment 8 2011-03-02 15:49:42 PST
http://trac.webkit.org/changeset/80174 It passed on win and linux. I'm still waiting for mac to finish cycling.
Hajime Morrita
Comment 9 2011-03-02 21:06:15 PST
Hi Tony, Thank you for your help! I thought we need the clobber the build, just because chromium builds did need it. But I don't know why. So if it can go without clobber, it's fine.
Note You need to log in before you can comment on or make changes to this bug.