Bug 55512

Summary: EventQueue needs to be ref counted
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mihaip, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mihaip: review+

Jeremy Orlow
Reported 2011-03-01 14:57:37 PST
EventQueue needs to be ref counted
Attachments
Patch (3.29 KB, patch)
2011-03-01 15:00 PST, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2011-03-01 15:49 PST, Jeremy Orlow 		mihaip: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2011-03-01 15:00:58 PST
Created attachment 84302 [details] Patch
Jeremy Orlow
Comment 2 2011-03-01 15:01:10 PST
Please review.
Mihai Parparita
Comment 3 2011-03-01 15:35:05 PST
Comment on attachment 84302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > Source/WebCore/dom/EventQueue.cpp:94 > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; RefPtr<EventQueue> protector(this) is a more common pattern for this: https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium Either way the name shouldn't start with m_ since it's not a member.
Jeremy Orlow
Comment 4 2011-03-01 15:49:24 PST
(In reply to comment #3) > (From update of attachment 84302 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > > > Source/WebCore/dom/EventQueue.cpp:94 > > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; > > RefPtr<EventQueue> protector(this) is a more common pattern for this: > https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium > > Either way the name shouldn't start with m_ since it's not a member. Oops...fixed.
Jeremy Orlow
Comment 5 2011-03-01 15:49:46 PST
Created attachment 84313 [details] Patch
Jeremy Orlow
Comment 6 2011-03-01 15:54:15 PST
Committed r80054: <http://trac.webkit.org/changeset/80054>
WebKit Review Bot
Comment 7 2011-03-01 16:18:04 PST
http://trac.webkit.org/changeset/80054 might have broken Chromium Win Release
Note You need to log in before you can comment on or make changes to this bug.