Bug 55494 – Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard

• Component: New Bugs
• Status: RESOLVED FIXED

Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard

Created attachment 84272 [details]
Patch

Created attachment 84279 [details]
Patch

[Mihai Parparita]

Comment on attachment 84279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84279&action=review

> LayoutTests/ChangeLog:13
> +        * platform/chromium-mac-snowleopard/media/video-layer-crash-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.

Snow Leopard baselines should go in platform/chromium-mac (see https://groups.google.com/a/google.com/group/chrome-webkit-gardening/browse_thread/thread/224d2c64f017e333).

Also, this file move doesn't get uploaded correctly by webkit-patch due to https://bugs.webkit.org/show_bug.cgi?id=49154. If you don't have committer access you'll need to have someone else land this for you.

Created attachment 84502 [details]
Patch

[WebKit Review Bot]

Attachment 84502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 84503 [details]
Patch

[Mihai Parparita]

Comment on attachment 84503 [details]
Patch

Actually, now that I've looked at the current results (http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&tests=media%2Fvideo-layer-crash.html&group=%40ToT%20-%20chromium.org) and patched this in, I'm not sure I understand this change.

As far as I can tell, the test is currently passing everywhere except on 10.6 (Snow Leopard). The patch currently only adds chromium-mac-leopard baselines, which won't help with that. I think the correct things to do would be to:
1) Move the current chromium-mac baselines (which are valid for Leopard only) to chromium-mac-leopard
2) Add new Snow Leopard baselines to chromium-mac
3) Remove the media/video-layer-crash.html lines from test_expectations.txt (both the MAC and LINUX ones)

Sorry if I'm misunderstanding anything, feel free to ping me in #webkit or on IM.

Created attachment 84579 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 84579 [details]
Patch

Clearing flags on attachment: 84579

Committed r80259: <http://trac.webkit.org/changeset/80259>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.