Summary: | Web Inspector: Searching on the Network panel doesn't do anything? | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||||||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, joshuajay, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys | ||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||
Attachments: |
|
Description
Matt Lilek
2011-03-01 11:49:30 PST
*** Bug 56398 has been marked as a duplicate of this bug. *** Created attachment 99639 [details]
[patch] initial version
Created attachment 99640 [details]
[patch] initial version. Unnecessary logging was removed.
Attachment 99639 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 99640 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 99642 [details]
[patch] initial version. with styles fixes.
Comment on attachment 99642 [details] [patch] initial version. with styles fixes. Attachment 99642 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8988025 New failing tests: inspector/audits/audits-panel-functional.html http/tests/inspector/resource-tree/resource-tree-mimetype.html inspector/elements/elements-panel-selection-on-refresh.html inspector/console/console-log-toString-object.html inspector/console/console-preserve-log.html inspector/debugger/debugger-reload-on-pause.html inspector/console/alert-toString-exception.html inspector/debugger/dom-breakpoints.html inspector/debugger/debugger-breakpoints-not-activated-on-reload.html inspector/console/console-uncaught-exception-in-eval.html http/tests/inspector/resource-har-conversion.html http/tests/inspector/resource-tree/resource-tree-reload.html Created attachment 99646 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 99642 [details] [patch] initial version. with styles fixes. View in context: https://bugs.webkit.org/attachment.cgi?id=99642&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1097 > + if (!(resource._displayName && resource._displayName.match(this._searchRegExp)) && Checking path is sufficient. > Source/WebCore/inspector/front-end/NetworkPanel.js:1101 > + if (resource.identifier in this._matchedResourcesIdMap) { no need for {} > Source/WebCore/inspector/front-end/NetworkPanel.js:1107 > + node._addStyleClass("search-matched-item"); See highlightSearchResult in utilities.js and its usages on how to highlight search match. Comment on attachment 99642 [details] [patch] initial version. with styles fixes. View in context: https://bugs.webkit.org/attachment.cgi?id=99642&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1105 > + this._matchedResourcesMap[resource.identifier] = true; Looks like this field is not used anywhere else, is it needed? > Source/WebCore/inspector/front-end/NetworkPanel.js:1157 > + this._searchRegExp = new RegExp(searchQuery,"i"); Please use createSearchRegex() from utilities.js here. > Source/WebCore/inspector/front-end/NetworkPanel.js:1170 > + if (!this._matchedResources.length) I can't find any place where this._matchedResources is updated. Created attachment 99803 [details]
[patch] initial version
Created attachment 99814 [details]
[patch] third version
"new RegExp" was replaced with createSearchRegexp
Comment on attachment 99814 [details]
[patch] third version
r- until the UI issues are not resolved.
Created attachment 99819 [details]
[patch] fourth version
It is toggle large view only when the highlighted element has matches only in the path section.
Created attachment 99844 [details]
[patch] fifth version
it supports sorting and filtering
Comment on attachment 99844 [details] [patch] fifth version View in context: https://bugs.webkit.org/attachment.cgi?id=99844&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1105 > + if (!refresh) Should matcher be refresh-aware? Created attachment 99956 [details]
[patch] next iteration.
_updateHighlightIfMatched was extracted from _matchResource
Comment on attachment 99956 [details] [patch] next iteration. Clearing flags on attachment: 99956 Committed r90556: <http://trac.webkit.org/changeset/90556> All reviewed patches have been landed. Closing bug. |