Bug 55487

Summary:

Expand ruby text when it is shorter than the ruby base

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Expand ruby text with default text-align when it is shorter than the ruby base	darin: review+

mitz

Reported 2011-03-01 11:31:19 PST

As shown in <http://www.w3.org/TR/jlreq/#fig2_3_19-en> and <http://www.w3.org/TR/jlreq/#fig2_3_21-en> <rdar://problem/8902714>

Attachments
Expand ruby text with default text-align when it is shorter than the ruby base (392.35 KB, patch) 2011-03-01 11:39 PST, mitz	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2011-03-01 11:39:28 PST

Created attachment 84259 [details] Expand ruby text with default text-align when it is shorter than the ruby base

Darin Adler

Comment 2 2011-03-01 11:41:15 PST

Comment on attachment 84259 [details] Expand ruby text with default text-align when it is shorter than the ruby base View in context: https://bugs.webkit.org/attachment.cgi?id=84259&action=review > Source/WebCore/rendering/RenderRubyText.cpp:59 > + ETextAlign textAlign = style()->textAlign(); > + if (textAlign != TAAUTO) > + return RenderBlock::textAlignmentForLine(endsWithSoftBreak); > + > + return JUSTIFY; Might be nice to have a why comment here.

mitz

Comment 3 2011-03-01 11:49:21 PST

Fixed in r80015. <http://trac.webkit.org/changeset/80015>

Note You need to log in before you can comment on or make changes to this bug.