Bug 55487 - Expand ruby text when it is shorter than the ruby base
Summary: Expand ruby text when it is shorter than the ruby base
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-01 11:31 PST by mitz
Modified: 2011-03-01 11:49 PST (History)
0 users

See Also:

Attachments
Expand ruby text with default text-align when it is shorter than the ruby base (392.35 KB, patch)
2011-03-01 11:39 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 mitz 2011-03-01 11:39:28 PST 
Created attachment 84259 [details]
Expand ruby text with default text-align when it is shorter than the ruby base
Comment 2 Darin Adler 2011-03-01 11:41:15 PST 
Comment on attachment 84259 [details]
Expand ruby text with default text-align when it is shorter than the ruby base

View in context: https://bugs.webkit.org/attachment.cgi?id=84259&action=review

> Source/WebCore/rendering/RenderRubyText.cpp:59
> +    ETextAlign textAlign = style()->textAlign();
> +    if (textAlign != TAAUTO)
> +        return RenderBlock::textAlignmentForLine(endsWithSoftBreak);
> +
> +    return JUSTIFY;

Might be nice to have a why comment here.
Comment 3 mitz 2011-03-01 11:49:21 PST 
Fixed in r80015.
<http://trac.webkit.org/changeset/80015>