Bug 55437

Summary: [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed Patch
mrobinson: review+
Updated ChangeLog
commit-queue: commit-queue-
Updated ChangeLog with reviewer name none

Joone Hur
Reported 2011-02-28 18:52:28 PST
When we create a cairo context through gdk_cairo_create, we need to use RefPtr instead of raw pointer.
Attachments
Proposed Patch (1.34 KB, patch)
2011-02-28 19:31 PST, Joone Hur 		mrobinson: review+
DetailsFormatted DiffDiff
Updated ChangeLog (1.33 KB, patch)
2011-02-28 22:06 PST, Joone Hur 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Updated ChangeLog with reviewer name (1.33 KB, patch)
2011-03-01 00:26 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2011-02-28 19:31:07 PST
Created attachment 84174 [details] Proposed Patch
Martin Robinson
Comment 2 2011-02-28 19:40:38 PST
Comment on attachment 84174 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84174&action=review Great. Thanks! > Source/WebKit/gtk/ChangeLog:10 > + Convert use of cairo_t to RefPtr<cairo_t> > + > + [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp > + https://bugs.webkit.org/show_bug.cgi?id=55437 > + > + * webkit/webkitwebview.cpp: I'd move the first description to after webkit/webkitwebview.cpp:
Joone Hur
Comment 3 2011-02-28 22:06:31 PST
Created attachment 84187 [details] Updated ChangeLog Thanks, Martin!
WebKit Commit Bot
Comment 4 2011-02-28 23:31:58 PST
Comment on attachment 84187 [details] Updated ChangeLog Rejecting attachment 84187 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 84187 from bug 55437. NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Full output: http://queues.webkit.org/results/8071550
Joone Hur
Comment 5 2011-03-01 00:26:29 PST
Created attachment 84197 [details] Updated ChangeLog with reviewer name I missed reviewer name.
WebKit Commit Bot
Comment 6 2011-03-01 00:46:38 PST
Comment on attachment 84197 [details] Updated ChangeLog with reviewer name Clearing flags on attachment: 84197 Committed r79977: <http://trac.webkit.org/changeset/79977>
WebKit Commit Bot
Comment 7 2011-03-01 00:46:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.