Bug 55430

Summary:

OwnArrayPtr.h’s LOOSE_OWN_ARRAY_PTR mode results in code that does not link

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review-
Patch	darin: review+

Description Mark Rowe (bdash) 2011-02-28 17:03:27 PST

OwnArrayPtr::set is lacking an implementation so using LOOSE_OWN_ARRAY_PTR results in code that doesn’t compile.

Comment 1 Mark Rowe (bdash) 2011-02-28 17:11:13 PST

Created attachment 84159 [details]
Patch

Comment 2 Mark Rowe (bdash) 2011-02-28 17:12:23 PST

Comment on attachment 84159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review

> Source/JavaScriptCore/wtf/OwnArrayPtr.h:114
> +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr)

This is obviously missing the necessary #ifdef.

Comment 3 Darin Adler 2011-02-28 17:16:58 PST

Comment on attachment 84159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review

> Source/JavaScriptCore/wtf/OwnArrayPtr.h:114
> +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr)

Needs to be inside an #ifdef.

Comment 4 Mark Rowe (bdash) 2011-02-28 17:19:29 PST

Created attachment 84160 [details]
Patch

Comment 5 WebKit Review Bot 2011-02-28 17:32:15 PST

Attachment 84159 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8074436

Comment 6 Mark Rowe (bdash) 2011-02-28 17:56:00 PST

Landed in r79955.