Bug 55430

Summary:

OwnArrayPtr.h’s LOOSE_OWN_ARRAY_PTR mode results in code that does not link

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review-
Patch	darin: review+

Mark Rowe (bdash)

Reported 2011-02-28 17:03:27 PST

OwnArrayPtr::set is lacking an implementation so using LOOSE_OWN_ARRAY_PTR results in code that doesn’t compile.

Attachments
Patch (1.71 KB, patch) 2011-02-28 17:11 PST, Mark Rowe (bdash)	darin: review-	Details Formatted Diff Diff
Patch (1.74 KB, patch) 2011-02-28 17:19 PST, Mark Rowe (bdash)	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2011-02-28 17:11:13 PST

Mark Rowe (bdash)

Comment 2 2011-02-28 17:12:23 PST

Comment on attachment 84159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review > Source/JavaScriptCore/wtf/OwnArrayPtr.h:114 > +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr) This is obviously missing the necessary #ifdef.

Darin Adler

Comment 3 2011-02-28 17:16:58 PST

Mark Rowe (bdash)

Comment 4 2011-02-28 17:19:29 PST

WebKit Review Bot

Comment 5 2011-02-28 17:32:15 PST

Mark Rowe (bdash)

Comment 6 2011-02-28 17:56:00 PST

Landed in r79955.

Note You need to log in before you can comment on or make changes to this bug.