Bug 55424 – Stop using DeprecatedPtr for the global exception slot

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Stop using DeprecatedPtr for the global exception slot

[Oliver Hunt]

Created attachment 84146 [details]
Patch

[Darin Adler]

Comment on attachment 84146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84146&action=review

> Source/JavaScriptCore/runtime/WriteBarrier.h:154
> +template <typename T> class GCRootPtr : public WriteBarrierBase<T> {

I’ve been using:

    template<typename T>

without the space after template, by analogy with the lack of space after a function name before its arguments. Just sayin’.

> Source/JavaScriptCore/runtime/WriteBarrier.h:159
> +        this->setWithoutWriteBarrier(value);

Why all this use of this? Wouldn’t it compile without it?

[Gavin Barraclough]

Comment on attachment 84146 [details]
Patch

looks sensible

[Oliver Hunt]

Committed r79948: <http://trac.webkit.org/changeset/79948>

[Geoffrey Garen]

Why not just use Global<T>?

What's the difference between Global<T> and GCRootPtr<T>? How do I know which one to use?

[Xan Lopez]

This might have broken some layout tests in a bunch of platforms, including SL.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79948 might have broken GTK Linux 64-bit Debug