| Summary: | Follow HTML5 spec for document.open() a little more closely | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 54355 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Gentilcore
2011-02-28 11:39:00 PST
Created attachment 84100 [details]
Patch
Adam, this is the missing check for the script-created parser that we talked about on Friday. Created attachment 84107 [details]
Patch
Comment on attachment 84107 [details]
Patch
This looks like progress. I'm glad we're doing this in small steps, but at some point we might need to make a more global change to make this state machine follow the spec (and sanity).
(In reply to comment #4) > (From update of attachment 84107 [details]) > This looks like progress. I'm glad we're doing this in small steps, but at some point we might need to make a more global change to make this state machine follow the spec (and sanity). Yeah, agreed. That is going to be a hairy patch, though. Comment on attachment 84107 [details] Patch Clearing flags on attachment: 84107 Committed r79944: <http://trac.webkit.org/changeset/79944> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/79944 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html fast/frames/iframe-plugin-load-remove-document-crash.html fast/frames/sandboxed-iframe-attribute-parsing.html fast/layers/clip-rects-transformed.html fast/replaced/object-with-non-empty-classid-triggers-fallback.html plugins/createScriptableObject-before-start.html plugins/destroy-on-setwindow.html plugins/destroy-plugin-from-callback.html plugins/destroy-stream-twice.html plugins/document-open.html plugins/evaluate-js-after-removing-plugin-element.html plugins/get-file-url.html plugins/get-url-that-the-resource-load-delegate-will-disallow.html plugins/get-url-with-javascript-destroying-plugin.html plugins/geturl-replace-query.html plugins/geturlnotify-during-document-teardown.html plugins/instance-available-before-stylesheets-loaded-object.html plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html plugins/js-from-destroy.html |