Bug 55385

Summary: Use Frame::ownerElement() directly where appropriate.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Description Andreas Kling 2011-02-28 09:00:57 PST
Don't take the roundabout way through frame->document->ownerElement which just checks that the document->frame is non-null.
Comment 1 Andreas Kling 2011-02-28 09:03:06 PST
Created attachment 84069 [details]
Proposed patch
Comment 2 Darin Adler 2011-02-28 09:45:45 PST
Comment on attachment 84069 [details]
Proposed patch

Ideally we’d remove redundant functions like these. It’s annoying to have the same function in both Document and Frame. We have many cases of this. Obviously we don’t want to go from Frame to Document and then have it just call back to Frame so this change is great given the current state of things.
Comment 3 Andreas Kling 2011-02-28 09:51:09 PST
Comment on attachment 84069 [details]
Proposed patch

Clearing flags on attachment: 84069

Committed r79875: <http://trac.webkit.org/changeset/79875>
Comment 4 Andreas Kling 2011-02-28 09:51:16 PST
All reviewed patches have been landed.  Closing bug.