Bug 55337

Summary: Force dictionary popup to use overlay type
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Sam Weinig
Reported 2011-02-27 17:24:18 PST
Force dictionary popup to use overlay type
Attachments
Patch (1.98 KB, patch)
2011-02-27 17:26 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-02-27 17:26:28 PST
Created attachment 84006 [details] Patch
mitz
Comment 2 2011-02-27 18:34:40 PST
Comment on attachment 84006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84006&action=review > Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:430 > + [m_wkView showDefinitionForAttributedString:attributedString.get() > + range:NSMakeRange(0, [attributedString.get() length]) > + options:options > + baselineOriginProvider:^(NSRange adjustedRange) { return (NSPoint)textBaselineOrigin; }]; Aligning arguments this way is not WebKit style. Please fix.
Sam Weinig
Comment 3 2011-02-27 20:35:37 PST
Landed in r79839.
Note You need to log in before you can comment on or make changes to this bug.